Skip to content

Adding metrics for checking case-insensitive sample/source names#6875

Merged
XingY merged 1 commit intodevelopfrom
fb_caseInsensitiveNameMetrics
Jul 24, 2025
Merged

Adding metrics for checking case-insensitive sample/source names#6875
XingY merged 1 commit intodevelopfrom
fb_caseInsensitiveNameMetrics

Conversation

@XingY
Copy link
Contributor

@XingY XingY commented Jul 24, 2025

Rationale

Adding metrics for case-insensitive sample/source names

Related Pull Requests

Changes

Tasks 📍

  • Manual Testing @labkey-susanh
  • modules.Experiment.duplicateCaseInsensitiveSampleNameCount
  • modules.Experiment.duplicateCaseInsensitiveDataNameCount
  • check sql server and postgres
  • Verify Fix

@XingY XingY requested a review from labkey-susanh July 24, 2025 16:58
@XingY XingY self-assigned this Jul 24, 2025
Copy link
Contributor

@labkey-susanh labkey-susanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified counts on Postgres. Should be made clear that this does not report the number of samples or data objects involved but the number of duplicate names. This will help us to know who would be affected by a switch to full case-insensitivity but we may later want to provide a report of the names to help users do proper renaming.

For SQL Server, I have verified that the computation of the metric does not produce an error. Since this database is already case-insensitive by default, my counts are 0.

@XingY XingY merged commit 2674195 into develop Jul 24, 2025
13 checks passed
@XingY XingY deleted the fb_caseInsensitiveNameMetrics branch July 24, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants